Removed workaround for old Webkit bug in the TinyMCE editor for selec… #9540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions of images and hr elements, because this workaround now causes problems in Google Chrome version 58.
|
I just noticed this problem is also manifested in Magento 1 shops in Chrome 58. So if Magento releases a new version for version 1, this should best be included as well I believe (maybe even in a SUPEE patch, so we can apply it to older Magento versions as well?). @okorshenko: any reasons why this PR is being ignored, or is it still under investigation by Magento? Thanks! |
omiroshnichenko
approved these changes
May 13, 2017
|
@hostep thank you for your contribution. Your Pull Request has been successfully merged |
magento-team
pushed a commit
that referenced
this pull request
Jun 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tions of images and hr elements, because this workaround now causes problems in Google Chrome version 58.
Description
This PR attempts to solve a new bug which popped up by upgrading Google Chrome to version 58.
In the TinyMCE editor, we can no longer select images (or widgets, which are represented by an image), so we can no longer edit images (or widgets) using the TinyMCE editor.
See #9518 for more detailed info with links to a bunch of external sources.
Fixed Issues (if relevant)
Manual testing scenarios
Failed to execute 'setBaseAndExtent' on 'Selection': There is no child at offset 1.Contribution checklist
Discussion
I only briefly tested these changes, only on Chrome 58 and Safari 10.1, so it would be highly appreciated if someone else can test all browsers which Magento supports and see if this doesn't break any other browser.
I applied the changes to all tiny_mce scripts I could find, although I think only the
tiny_mce_src.jsone is used in the backend of Magento. But since you bundle all the other scripts in Magento, It could be possible that someone is using another script, so I assumed this should be fixed in all the tiny_mce scripts.Also: the minified tiny_mce scripts were manually edited, I don't know the command which was being used to generate the minified scripts, so please double check that my manual edits are ok.
Since this bug will probably popup with a lot of shopowners in the near future, this fix should get a bit of a higher priority and should also get backported to Magento versions 2.1 and 2.0 as soon as possible.
If this PR is accepted, I can create a backport for version 2.1, but not sure how backporting to 2.0 is supposed to work?